Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pernight bug and remove desi_run_night script #2339

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Conversation

akremin
Copy link
Member

@akremin akremin commented Aug 23, 2024

This solves issue #2338 with a simple two-line fix. I tested it with dry_run_level=1 on two separate nights, which were both successful. Those tests should provide full coverage for the generation of a processing table row. The code no longer crashes when requesting pernight redshifts, and the pernight job rows have unique internal ID's and the correct metadata.

This PR also removes the desi_run_night but not the underlying Python code, just in case we want to bring it back in the future (though that is unlikely). This will prevent people from using it accidentally instead of the new and similarly named desi_proc_night.

@sbailey sbailey merged commit a703596 into main Aug 23, 2024
26 checks passed
@sbailey sbailey deleted the pernight_z_bugfix branch August 23, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants